remove old brand banner
This commit is contained in:
@@ -10,6 +10,11 @@ function read(relativePath) {
|
||||
return fs.readFileSync(filePath, 'utf8');
|
||||
}
|
||||
|
||||
function assertMissing(relativePath, message) {
|
||||
const filePath = path.join(__dirname, '..', relativePath);
|
||||
assert(!fs.existsSync(filePath), message || `${relativePath} should not exist`);
|
||||
}
|
||||
|
||||
function assertIncludes(haystack, needle, message) {
|
||||
assert(
|
||||
haystack.includes(needle),
|
||||
@@ -30,6 +35,7 @@ const topbar = read('templates/partials/header/topbar.tpl');
|
||||
const theme = read('theme.scss');
|
||||
const stylesheet = read('scss/westgate/_topbar.scss');
|
||||
const client = read('public/client.js');
|
||||
const themeHooks = read('lib/theme.js');
|
||||
|
||||
assertIncludes(
|
||||
header,
|
||||
@@ -51,6 +57,11 @@ assertIncludes(
|
||||
'@import "./scss/westgate/topbar";',
|
||||
'theme.scss should import the focused topbar partial'
|
||||
);
|
||||
assertExcludes(
|
||||
theme,
|
||||
'@import "./scss/westgate/header";',
|
||||
'theme.scss should not import the removed brand banner stylesheet'
|
||||
);
|
||||
assertIncludes(
|
||||
stylesheet,
|
||||
'.wg-topbar',
|
||||
@@ -94,3 +105,21 @@ assertIncludes(topbar, '{{{ if config.loggedIn }}}', 'Topbar should branch on th
|
||||
assertIncludes(topbar, '{{{ if canChat }}}', 'Chat controls should remain permission-gated');
|
||||
assertIncludes(topbar, '{{{ if allowRegistration }}}', 'Registration should remain server-gated');
|
||||
assertIncludes(topbar, '{{{ each navigation }}}', 'Topbar should render ACP Navigation items');
|
||||
|
||||
assertMissing(
|
||||
'templates/partials/header/brand.tpl',
|
||||
'Theme should inherit Harmony brand markup instead of shipping the removed Westgate brand banner override'
|
||||
);
|
||||
assertMissing(
|
||||
'scss/westgate/_header.scss',
|
||||
'Removed brand banner styles should not remain in the theme'
|
||||
);
|
||||
assertMissing(
|
||||
'public/images/plum-header-bg.png',
|
||||
'Removed brand banner background should not remain in static assets'
|
||||
);
|
||||
assertExcludes(
|
||||
themeHooks,
|
||||
'brand-header',
|
||||
'Removed brand banner widget area should not remain registered'
|
||||
);
|
||||
|
||||
Reference in New Issue
Block a user