ShadowsOverWestgate/sow-nodebb-theme
3
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Activity

Render wiki badges in global search results #13

New Issue
Closed
opened 2026-07-02 09:48:35 +00:00 by archvillainette · 1 comment
archvillainette commented 2026-07-02 09:48:35 +00:00
Owner
Copy Link
Copy Source

Active spec: docs/superpowers/specs/2026-07-02-wiki-search-result-badge-design.md
Driven by plugin spec: sow-nodebb-plugin-wiki/docs/superpowers/specs/2026-07-02-wiki-global-search-design.md

Scope:

  • Render an inline wiki badge/icon for search rows with isWikiArticle=true.
  • Rewrite those result links to wikiPath.
  • Cover both the full /search page and the quick-search dropdown.
  • Keep forum search results visually and behaviorally unchanged.
  • Add styles under scss/ using existing Westgate theme patterns; no new dependencies.

Planning decision to resolve first:

  • Prefer a small template override if the pinned NodeBB/Harmony partials isolate the result row cleanly.
  • Fall back to public/client.js decoration only if the stock partials are awkward to override safely.

Acceptance:

  • Wiki search hits show a clear theme-consistent Wiki badge/icon.
  • Wiki search hit links point to /wiki/... from wikiPath.
  • Forum hits remain unchanged.
  • Both quick-search dropdown and /search page are covered.

Dependency:

  • End-to-end verification depends on the wiki plugin emitting isWikiArticle and wikiPath.
Active spec: docs/superpowers/specs/2026-07-02-wiki-search-result-badge-design.md Driven by plugin spec: sow-nodebb-plugin-wiki/docs/superpowers/specs/2026-07-02-wiki-global-search-design.md Scope: - Render an inline wiki badge/icon for search rows with isWikiArticle=true. - Rewrite those result links to wikiPath. - Cover both the full /search page and the quick-search dropdown. - Keep forum search results visually and behaviorally unchanged. - Add styles under scss/ using existing Westgate theme patterns; no new dependencies. Planning decision to resolve first: - Prefer a small template override if the pinned NodeBB/Harmony partials isolate the result row cleanly. - Fall back to public/client.js decoration only if the stock partials are awkward to override safely. Acceptance: - Wiki search hits show a clear theme-consistent Wiki badge/icon. - Wiki search hit links point to /wiki/... from wikiPath. - Forum hits remain unchanged. - Both quick-search dropdown and /search page are covered. Dependency: - End-to-end verification depends on the wiki plugin emitting isWikiArticle and wikiPath.
archvillainette added the
Priority
Critical
1
Kind/Enhancement labels 2026-07-02 09:50:19 +00:00
archvillainette commented 2026-07-18 07:44:21 +00:00
Author
Owner
Copy Link
Copy Source

Implemented on main. Wiki search rows carry isWikiArticle/wikiPath from the plugin; the theme renders an inline Wiki badge and rewrites the link to wikiPath in all three partials — partials/search-results.tpl, partials/quick-search-results.tpl, partials/posts_list_item.tpl — styled via scss/westgate/_search.scss (.westgate-wiki-badge), with a contract test at tests/wiki-search-badge-contract.test.js. Forum results are unchanged. Needs only a deploy + dbsearch reindex to show live. Closing as done.

Implemented on `main`. Wiki search rows carry `isWikiArticle`/`wikiPath` from the plugin; the theme renders an inline Wiki badge and rewrites the link to `wikiPath` in all three partials — `partials/search-results.tpl`, `partials/quick-search-results.tpl`, `partials/posts_list_item.tpl` — styled via `scss/westgate/_search.scss` (`.westgate-wiki-badge`), with a contract test at `tests/wiki-search-badge-contract.test.js`. Forum results are unchanged. Needs only a deploy + dbsearch reindex to show live. Closing as done.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
needs-triage
wayfinder:grilling
wayfinder:map
wayfinder:prototype
wayfinder:research
wayfinder:task
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No labels Kind/Enhancement
Priority
Critical
1
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
XeroTwo archvillainette gitea-bot xtul
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ShadowsOverWestgate/sow-nodebb-theme#13