fix: keep gold btn-primary plate on topic Reply button #35

Merged
archvillainette merged 2 commits from fix/reply-button-gold into main 2026-07-19 08:55:18 +00:00
Owner

The .topic-sidebar-tools .btn flattening override also hit the Reply button (btn-primary in harmony's reply-button partial), turning it grey. Exclude btn-primary so Reply keeps the theme's gold plate.

Fixes #34

The `.topic-sidebar-tools .btn` flattening override also hit the Reply button (`btn-primary` in harmony's reply-button partial), turning it grey. Exclude `btn-primary` so Reply keeps the theme's gold plate. Fixes #34
archvillainette added 1 commit 2026-07-19 08:14:15 +00:00
The topic-sidebar-tools flattening override was hitting the Reply
button (btn-primary) too, turning it grey. Exclude btn-primary so
Reply keeps the theme's gold plate.

Fixes #34
archvillainette added 1 commit 2026-07-19 08:18:43 +00:00
- Blockquotes: replace the 3px gold side-stripe and warm-brown fill
  with a full 1px gilt border and plum tint, per the Gilt Edge Rule
- Snap pagination shadow alpha to the documented velvet-hover value
  and unify the vote glyph size at 0.95rem
- Document the already-shipped code-syntax and vote-state colors and
  the small type steps (0.95/0.82/0.78rem) in DESIGN.md + sidecar
archvillainette scheduled this pull request to auto merge when all checks succeed 2026-07-19 08:41:27 +00:00
archvillainette canceled auto merging this pull request when all checks succeed 2026-07-19 08:43:22 +00:00
gitea-bot approved these changes 2026-07-19 08:48:41 +00:00
gitea-bot left a comment
Member

LGTM. :not(.btn-primary) on the sidebar-tools flattening rule is the correct root fix: the old background: ... !important shorthand was wiping the gold gradient from _controls.scss, and the exclusion keeps any future primary button in that container gold too, consistent with the theme's one-gold-surface convention.

Minor notes, non-blocking:

  • Commit 376caf4 bundles unrelated design churn (design.json colors, DESIGN.md type ramp, blockquote restyle, icon/shadow tweaks) not mentioned in the PR body — fine per our reuse-the-branch convention, just noting the diff is mostly that.
  • crypt-black tonalRamp now has 9 entries while all others have 8; double-check the design-detector doesn't assume a fixed ramp length.
LGTM. `:not(.btn-primary)` on the sidebar-tools flattening rule is the correct root fix: the old `background: ... !important` shorthand was wiping the gold gradient from `_controls.scss`, and the exclusion keeps any future primary button in that container gold too, consistent with the theme's one-gold-surface convention. Minor notes, non-blocking: - Commit 376caf4 bundles unrelated design churn (design.json colors, DESIGN.md type ramp, blockquote restyle, icon/shadow tweaks) not mentioned in the PR body — fine per our reuse-the-branch convention, just noting the diff is mostly that. - `crypt-black` tonalRamp now has 9 entries while all others have 8; double-check the design-detector doesn't assume a fixed ramp length.
archvillainette merged commit 5d37548da0 into main 2026-07-19 08:55:18 +00:00
archvillainette deleted branch fix/reply-button-gold 2026-07-19 08:55:18 +00:00
Sign in to join this conversation.