ShadowsOverWestgate/sow-nodebb-theme
3
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Activity

Wiki prose parity cleanup: dead CKEditor CSS, duplicated measure, static parity test #64

New Issue
Open
opened 2026-07-31 14:19:06 +00:00 by archvillainette · 0 comments
archvillainette commented 2026-07-31 14:19:06 +00:00
Owner
Copy Link
Copy Source

Follow-up build work from the parity contract in #52 (part of map #47). Not a map ticket — nothing left to decide here.

  1. Delete dead editor-only prose CSS. scss/westgate/_wiki-prose.scss carries ~50 lines targeting .ck.ck-editor__editable_inline.ck-content (roughly :341–:540). The editor is TipTap; nothing emits those classes. They are editor-only copies of heading rules — the same shape that broke justification.
  2. Collapse the duplicated reading measure. _wiki-prose.scss:228 (reader .wiki-content-layout) and :236 (compose editable) both hardcode 58rem. One meaning, two constants. Set --wiki-prose-measure instead; the plugin already applies it to both surfaces (wiki-article-body.css:79, default 70ch).
  3. Add the static parity test. Fail on any prose-affecting property reached through a reader-only ancestor (.wiki-page-content, .wiki-with-fab, .wiki-content-layout, .wiki-namespace-index) or an editor-only ancestor (.westgate-wiki-compose, .wiki-editor__*, .ProseMirror-*). Chrome properties are whitelisted.

Alignment ownership (move justify + hyphens + opt-out set into the plugin behind --wiki-prose-text-align) is plugin work — file in sow-nodebb-plugin-wiki when this lands.

Verify in the live dev stack on both reader and editor, per #52.

Follow-up build work from the parity contract in #52 (part of map #47). Not a map ticket — nothing left to decide here. 1. **Delete dead editor-only prose CSS.** `scss/westgate/_wiki-prose.scss` carries ~50 lines targeting `.ck.ck-editor__editable_inline.ck-content` (roughly :341–:540). The editor is TipTap; nothing emits those classes. They are editor-only copies of heading rules — the same shape that broke justification. 2. **Collapse the duplicated reading measure.** `_wiki-prose.scss:228` (reader `.wiki-content-layout`) and `:236` (compose editable) both hardcode `58rem`. One meaning, two constants. Set `--wiki-prose-measure` instead; the plugin already applies it to both surfaces (`wiki-article-body.css:79`, default `70ch`). 3. **Add the static parity test.** Fail on any prose-affecting property reached through a reader-only ancestor (`.wiki-page-content`, `.wiki-with-fab`, `.wiki-content-layout`, `.wiki-namespace-index`) or an editor-only ancestor (`.westgate-wiki-compose`, `.wiki-editor__*`, `.ProseMirror-*`). Chrome properties are whitelisted. Alignment ownership (move justify + hyphens + opt-out set into the plugin behind `--wiki-prose-text-align`) is plugin work — file in sow-nodebb-plugin-wiki when this lands. Verify in the live dev stack on **both** reader and editor, per #52.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
needs-triage
wayfinder:grilling
wayfinder:map
wayfinder:prototype
wayfinder:research
wayfinder:task
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
XeroTwo archvillainette gitea-bot xtul
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ShadowsOverWestgate/sow-nodebb-theme#64