"first_null_row" configuration option
This commit is contained in:
@@ -217,10 +217,17 @@ type TopDataConfig struct {
|
||||
PackageTLK string `json:"package_tlk" yaml:"package_tlk"`
|
||||
ValueEncodings []TopDataValueEncodingConfig `json:"value_encodings" yaml:"value_encodings"`
|
||||
ValueDefaults []TopDataValueDefaultConfig `json:"value_defaults" yaml:"value_defaults"`
|
||||
RowGeneration []TopDataRowGenerationConfig `json:"row_generation" yaml:"row_generation"`
|
||||
ClassFeatInjections TopDataClassFeatInjectionConfig `json:"class_feat_injections" yaml:"class_feat_injections"`
|
||||
Wiki TopDataWikiConfig `json:"wiki" yaml:"wiki"`
|
||||
}
|
||||
|
||||
type TopDataRowGenerationConfig struct {
|
||||
Dataset string `json:"dataset,omitempty" yaml:"dataset,omitempty"`
|
||||
Namespace string `json:"namespace,omitempty" yaml:"namespace,omitempty"`
|
||||
Mode string `json:"mode" yaml:"mode"`
|
||||
}
|
||||
|
||||
type TopDataClassFeatInjectionConfig struct {
|
||||
GlobalFeats []TopDataClassFeatGlobalRule `json:"global_feats" yaml:"global_feats"`
|
||||
ClassSkillMasterfeats []TopDataClassFeatMasterfeatRule `json:"class_skill_masterfeats" yaml:"class_skill_masterfeats"`
|
||||
@@ -606,6 +613,7 @@ func (p *Project) ValidateLayout() error {
|
||||
failures = append(failures, validateGeneratedConfig(effective.Generated)...)
|
||||
failures = append(failures, validateTopDataValueEncodings(effective.TopData.ValueEncodings)...)
|
||||
failures = append(failures, validateTopDataValueDefaults(effective.TopData.ValueDefaults)...)
|
||||
failures = append(failures, validateTopDataRowGeneration(effective.TopData.RowGeneration)...)
|
||||
failures = append(failures, validateTopDataClassFeatInjections(effective.TopData.ClassFeatInjections)...)
|
||||
failures = append(failures, validateRelativePath("scripts.cache", effective.Scripts.Cache)...)
|
||||
failures = append(failures, validateRelativePath("scripts.source_dir", effective.Scripts.SourceDir)...)
|
||||
@@ -805,6 +813,33 @@ func validateTopDataValueDefaults(defaults []TopDataValueDefaultConfig) []error
|
||||
return failures
|
||||
}
|
||||
|
||||
func validateTopDataRowGeneration(rules []TopDataRowGenerationConfig) []error {
|
||||
failures := []error{}
|
||||
seen := map[string]struct{}{}
|
||||
for index, rule := range rules {
|
||||
prefix := fmt.Sprintf("topdata.row_generation[%d]", index)
|
||||
dataset := strings.TrimSpace(rule.Dataset)
|
||||
namespace := strings.TrimSpace(rule.Namespace)
|
||||
if dataset == "" {
|
||||
dataset = namespace
|
||||
}
|
||||
if dataset == "" {
|
||||
failures = append(failures, fmt.Errorf("%s.dataset is required", prefix))
|
||||
}
|
||||
switch strings.TrimSpace(rule.Mode) {
|
||||
case "", "after_base", "first_null_row":
|
||||
default:
|
||||
failures = append(failures, fmt.Errorf("%s.mode %q is not supported", prefix, rule.Mode))
|
||||
}
|
||||
key := filepath.ToSlash(dataset)
|
||||
if _, ok := seen[key]; ok {
|
||||
failures = append(failures, fmt.Errorf("%s duplicates an earlier dataset row generation rule", prefix))
|
||||
}
|
||||
seen[key] = struct{}{}
|
||||
}
|
||||
return failures
|
||||
}
|
||||
|
||||
func validateTopDataClassFeatInjections(config TopDataClassFeatInjectionConfig) []error {
|
||||
failures := []error{}
|
||||
for index, rule := range config.GlobalFeats {
|
||||
|
||||
Reference in New Issue
Block a user