Fixing release queue

2026-05-23 21:28:52 +02:00
parent ed2ad4f9a0
commit 3d42fc70bc
3 changed files with 125 additions and 10 deletions
@@ -76,6 +76,94 @@ func TestDeployWikiDryRunDoesNotWriteRemoteOrManifest(t *testing.T) {
 	}
 }

+func TestDeployWikiReportsPlanningProgressBeforeRemoteWork(t *testing.T) {
+	root := t.TempDir()
+	sourceDir := filepath.Join(root, "pages")
+	if err := os.MkdirAll(filepath.Join(sourceDir, "skills"), 0755); err != nil {
+		t.Fatalf("create source dir: %v", err)
+	}
+	generated := `<!-- sow-topdata-wiki:page=skills:athletics -->
+<!-- sow-topdata-wiki:managed:start hash="sha256:local" -->
+<h1>Athletics</h1>
+<!-- sow-topdata-wiki:managed:end -->
+`
+	if err := os.WriteFile(filepath.Join(sourceDir, "skills", "athletics.html"), []byte(generated), 0644); err != nil {
+		t.Fatalf("write source page: %v", err)
+	}
+
+	progress := []string{}
+	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		switch {
+		case r.Method == http.MethodGet && r.URL.Path == "/api/v3/plugins/westgate-wiki/namespace/3/pages":
+			w.Header().Set("Content-Type", "application/json")
+			_ = json.NewEncoder(w).Encode(map[string]any{"response": map[string]any{"pages": []map[string]any{}, "hasMore": false}})
+		default:
+			t.Fatalf("unexpected request %s %s", r.Method, r.URL.String())
+		}
+	}))
+	defer server.Close()
+
+	_, err := DeployWikiWithOptions(&project.Project{}, DeployWikiOptions{
+		SourceDir:    sourceDir,
+		Endpoint:     server.URL,
+		Token:        "nodebb-token",
+		ManifestPath: filepath.Join(root, "deploy-manifest.json"),
+		CategoryIDs:  map[string]int{"skills": 3},
+		DryRun:       true,
+		AllowCreates: true,
+	}, func(message string) {
+		progress = append(progress, message)
+	})
+	if err != nil {
+		t.Fatalf("DeployWikiWithOptions dry run failed: %v", err)
+	}
+
+	joined := strings.Join(progress, "\n")
+	for _, expected := range []string{
+		"Collecting local wiki pages from",
+		"Loaded 1 local wiki page(s)",
+		"Loaded wiki deploy manifest",
+		"Planning NodeBB wiki deploy for 1 local page(s)",
+		"Listing NodeBB wiki namespace category 3",
+	} {
+		if !strings.Contains(joined, expected) {
+			t.Fatalf("expected progress %q, got:\n%s", expected, joined)
+		}
+	}
+}
+
+func TestNodeBBNamespacePaginationRejectsRepeatedCursor(t *testing.T) {
+	requests := 0
+	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		requests++
+		if requests > 2 {
+			w.WriteHeader(http.StatusInternalServerError)
+			return
+		}
+		w.Header().Set("Content-Type", "application/json")
+		_ = json.NewEncoder(w).Encode(map[string]any{
+			"response": map[string]any{
+				"pages":      []map[string]any{},
+				"hasMore":    true,
+				"nextCursor": "same-cursor",
+			},
+		})
+	}))
+	defer server.Close()
+
+	client := newNodeBBClient(server.URL, "nodebb-token")
+	_, err := client.listNamespacePages(9)
+	if err == nil {
+		t.Fatal("expected repeated cursor error")
+	}
+	if !strings.Contains(err.Error(), "repeated pagination cursor") {
+		t.Fatalf("expected repeated cursor error, got %v", err)
+	}
+	if requests != 2 {
+		t.Fatalf("expected pagination to stop after repeated cursor, got %d requests", requests)
+	}
+}
+
 func TestCollectLocalPagesReadsGeneratedPageIDFromMarkerWhenPathIsTitleBased(t *testing.T) {
 	root := t.TempDir()
 	sourceDir := filepath.Join(root, "pages")