Goodbye legacy DokuWiki translators...

2026-05-24 07:32:56 +02:00
parent 025995815d
commit 418cd2fa69
6 changed files with 451 additions and 289 deletions
@@ -327,6 +327,48 @@ func TestCollectLocalPagesReadsCanonicalPublicPathFromPageIndex(t *testing.T) {
 	}
 }

+func TestCollectLocalPagesReadsTitleFromPageIndexForHeadinglessHTML(t *testing.T) {
+	root := t.TempDir()
+	sourceDir := filepath.Join(root, "pages")
+	if err := os.MkdirAll(filepath.Join(sourceDir, "spells"), 0755); err != nil {
+		t.Fatalf("create source dir: %v", err)
+	}
+	generated := `<!-- sow-topdata-wiki:page=spells:acid_fog -->
+<!-- sow-topdata-wiki:managed:start hash="sha256:local" -->
+<p>Generated acid fog page.</p>
+<table><tbody><tr><th>School</th><td>Conjuration</td></tr></tbody></table>
+<!-- sow-topdata-wiki:managed:end -->
+`
+	if err := os.WriteFile(filepath.Join(sourceDir, "spells", "Acid_Fog.html"), []byte(generated), 0644); err != nil {
+		t.Fatalf("write source page: %v", err)
+	}
+	if err := saveWikiPageIndex(filepath.Join(root, "page-index.json"), wikiPageIndex{
+		Version: wikiGeneratorVersion,
+		Pages: []wikiPageIndexEntry{
+			{
+				PageID:     "spells:acid_fog",
+				Title:      "Acid Fog",
+				PublicPath: "Spells/Acid_Fog",
+				OutputPath: "pages/spells/Acid_Fog.html",
+			},
+		},
+	}); err != nil {
+		t.Fatalf("write page index: %v", err)
+	}
+
+	pages, err := collectLocalPages(sourceDir, []string{"spells"})
+	if err != nil {
+		t.Fatalf("collectLocalPages failed: %v", err)
+	}
+	page := pages["spells:acid_fog"]
+	if page.Title != "Acid Fog" {
+		t.Fatalf("expected page-index title for headingless HTML, got %#v", page)
+	}
+	if page.PublicPath != "Spells/Acid_Fog" {
+		t.Fatalf("expected page-index public path for headingless HTML, got %#v", page)
+	}
+}
+
 func TestExtractWikiPagePublicPathAcceptsCanonicalSlashPath(t *testing.T) {
 	content := `<!-- sow-topdata-wiki:page=spells:pdk:fear public_path="Magic/Fear" -->
 <!-- sow-topdata-wiki:managed:start hash="sha256:local" -->
@@ -997,6 +1039,154 @@ func TestDeployWikiRenamesManagedTopicWhenGeneratedTitleChanges(t *testing.T) {
 	}
 }

+func TestDeployWikiDoesNotRenameHeadinglessPageToPageIDFallback(t *testing.T) {
+	root := t.TempDir()
+	sourceDir := filepath.Join(root, "pages")
+	if err := os.MkdirAll(filepath.Join(sourceDir, "spells"), 0755); err != nil {
+		t.Fatalf("create source dir: %v", err)
+	}
+	generated := `<!-- sow-topdata-wiki:page=spells:acid_fog -->
+<!-- sow-topdata-wiki:managed:start hash="sha256:local" -->
+<p>Generated acid fog page.</p>
+<table><tbody><tr><th>School</th><td>Conjuration</td></tr></tbody></table>
+<!-- sow-topdata-wiki:managed:end -->
+`
+	if err := os.WriteFile(filepath.Join(sourceDir, "spells", "Acid_Fog.html"), []byte(generated), 0644); err != nil {
+		t.Fatalf("write source page: %v", err)
+	}
+	if err := saveWikiPageIndex(filepath.Join(root, "page-index.json"), wikiPageIndex{
+		Version: wikiGeneratorVersion,
+		Pages: []wikiPageIndexEntry{
+			{PageID: "spells:acid_fog", Title: "Acid Fog", PublicPath: "Spells/Acid_Fog", OutputPath: "pages/spells/Acid_Fog.html"},
+		},
+	}); err != nil {
+		t.Fatalf("write page index: %v", err)
+	}
+	manifestPath := filepath.Join(root, "deploy-manifest.json")
+	if err := saveDeployManifest(manifestPath, wikiDeployManifest{
+		Version: "nodebb-v1",
+		Pages: map[string]wikiDeployManifestPage{
+			"spells:acid_fog": {
+				Hash:       computeManagedHash(generated),
+				Title:      "Acid Fog",
+				TopicTitle: "Acid Fog",
+				Namespace:  "spells",
+				TID:        7,
+				PID:        42,
+				CID:        5,
+			},
+		},
+	}); err != nil {
+		t.Fatalf("write deploy manifest: %v", err)
+	}
+
+	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		t.Fatalf("headingless unchanged page must not call NodeBB, got %s %s", r.Method, r.URL.String())
+	}))
+	defer server.Close()
+
+	result, err := DeployWikiWithOptions(&project.Project{}, DeployWikiOptions{
+		SourceDir:    sourceDir,
+		Endpoint:     server.URL,
+		Token:        "nodebb-token",
+		ManifestPath: manifestPath,
+	}, nil)
+	if err != nil {
+		t.Fatalf("DeployWikiWithOptions headingless skip failed: %v", err)
+	}
+	if result.Renamed != 0 || result.Updated != 0 || result.Skipped != 1 {
+		t.Fatalf("expected headingless page to skip without page-id fallback rename, got %#v", result)
+	}
+}
+
+func TestDeployWikiRenamesBrokenHeadinglessFallbackTitleBackToPageIndexTitle(t *testing.T) {
+	root := t.TempDir()
+	sourceDir := filepath.Join(root, "pages")
+	if err := os.MkdirAll(filepath.Join(sourceDir, "spells"), 0755); err != nil {
+		t.Fatalf("create source dir: %v", err)
+	}
+	generated := `<!-- sow-topdata-wiki:page=spells:acid_fog -->
+<!-- sow-topdata-wiki:managed:start hash="sha256:local" -->
+<p>Generated acid fog page.</p>
+<table><tbody><tr><th>School</th><td>Conjuration</td></tr></tbody></table>
+<!-- sow-topdata-wiki:managed:end -->
+`
+	if err := os.WriteFile(filepath.Join(sourceDir, "spells", "Acid_Fog.html"), []byte(generated), 0644); err != nil {
+		t.Fatalf("write source page: %v", err)
+	}
+	if err := saveWikiPageIndex(filepath.Join(root, "page-index.json"), wikiPageIndex{
+		Version: wikiGeneratorVersion,
+		Pages: []wikiPageIndexEntry{
+			{PageID: "spells:acid_fog", Title: "Acid Fog", PublicPath: "Spells/Acid_Fog", OutputPath: "pages/spells/Acid_Fog.html"},
+		},
+	}); err != nil {
+		t.Fatalf("write page index: %v", err)
+	}
+	manifestPath := filepath.Join(root, "deploy-manifest.json")
+	if err := saveDeployManifest(manifestPath, wikiDeployManifest{
+		Version: "nodebb-v1",
+		Pages: map[string]wikiDeployManifestPage{
+			"spells:acid_fog": {
+				Hash:       computeManagedHash(generated),
+				Title:      "Acid_fog",
+				TopicTitle: "Acid_fog",
+				Namespace:  "spells",
+				TID:        7,
+				PID:        42,
+				CID:        5,
+			},
+		},
+	}); err != nil {
+		t.Fatalf("write deploy manifest: %v", err)
+	}
+
+	renameCalls := 0
+	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		switch {
+		case r.Method == http.MethodGet && r.URL.Path == "/api/v3/topics/7":
+			w.Header().Set("Content-Type", "application/json")
+			_ = json.NewEncoder(w).Encode(map[string]any{
+				"response": map[string]any{"tid": 7, "title": "Acid_fog", "mainPid": 42},
+			})
+		case r.Method == http.MethodPut && r.URL.Path == "/api/v3/plugins/westgate-wiki/page/move":
+			renameCalls++
+			var req struct {
+				TID   int    `json:"tid"`
+				CID   int    `json:"cid"`
+				Title string `json:"title"`
+			}
+			if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
+				t.Fatalf("decode rename request: %v", err)
+			}
+			if req.TID != 7 || req.CID != 5 || req.Title != "Acid Fog" {
+				t.Fatalf("unexpected rename request: %#v", req)
+			}
+			w.Header().Set("Content-Type", "application/json")
+			_ = json.NewEncoder(w).Encode(map[string]any{"response": map[string]any{"tid": 7}})
+		default:
+			t.Fatalf("unexpected request %s %s", r.Method, r.URL.String())
+		}
+	}))
+	defer server.Close()
+
+	result, err := DeployWikiWithOptions(&project.Project{}, DeployWikiOptions{
+		SourceDir:    sourceDir,
+		Endpoint:     server.URL,
+		Token:        "nodebb-token",
+		ManifestPath: manifestPath,
+	}, nil)
+	if err != nil {
+		t.Fatalf("DeployWikiWithOptions headingless title repair failed: %v", err)
+	}
+	if result.Renamed != 1 || result.Updated != 0 || result.Skipped != 1 || renameCalls != 1 {
+		t.Fatalf("expected one title repair rename and skipped body update, result=%#v renameCalls=%d", result, renameCalls)
+	}
+	entry := loadDeployManifest(manifestPath).Pages["spells:acid_fog"]
+	if entry.Title != "Acid Fog" || entry.TopicTitle != "Acid Fog" {
+		t.Fatalf("expected repaired manifest title from page-index, got %#v", entry)
+	}
+}
+
 func TestDeployWikiAdoptsExistingNodeBBPageWhenManifestIsMissingWithoutCreate(t *testing.T) {
 	root := t.TempDir()
 	sourceDir := filepath.Join(root, "pages")