Title normalization hot fix

2026-05-21 21:14:25 +02:00
parent 74c5ea34e1
commit 6790274d95
3 changed files with 64 additions and 8 deletions
@@ -2994,6 +2994,59 @@ func TestGeneratedWeaponFeatTitleStyleUsesSourceDisplayNameWithStableIdentity(t
 	}
 }

+func TestGeneratedWeaponFeatTitleStyleRewritesExistingFamilyFeatName(t *testing.T) {
+	root := testProjectRoot(t)
+	writeFeatGeneratedHarness(t, root, map[string]string{
+		"weapon_focus.json": `{
+  "family": "weapon_focus",
+  "family_key": "weapon_focus",
+  "template": "masterfeats:weaponfocus",
+  "name_prefix": "Weapon Focus",
+  "label_prefix": "FEAT_WEAPON_FOCUS",
+  "constant_prefix": "FEAT_WEAPON_FOCUS",
+  "identity_source": "child_source_value",
+  "child_source": {"dataset":"baseitems","column":"WeaponFocusFeat"},
+  "title_style": {"child_case":"lower","child_parenthetical":"preserve"},
+  "overrides": {}
+}` + "\n",
+	}, map[string]int{"feat:weapon_focus_dwaxe": 3003})
+	writeFile(t, filepath.Join(root, "topdata", "base_dialog.json"), `{
+  "entries": {
+    "83310": {"text": "Dwarven Waraxe"}
+  }
+}`+"\n")
+	writeFile(t, filepath.Join(root, "topdata", "data", "baseitems", "base.json"), `{
+  "output": "baseitems.2da",
+  "columns": ["label", "Name", "WeaponFocusFeat"],
+  "rows": [
+    {"id": 108, "key": "baseitems:dwarvenwaraxe", "label": "dwaxe", "Name": "83310", "WeaponFocusFeat": "3003"}
+  ]
+}`+"\n")
+	writeFile(t, filepath.Join(root, "topdata", "data", "baseitems", "lock.json"), `{"baseitems:dwarvenwaraxe":108}`+"\n")
+	writeFile(t, filepath.Join(root, "topdata", "data", "feat", "base.json"), `{
+  "output": "feat.2da",
+  "compare_reference": false,
+  "columns": ["LABEL","FEAT","DESCRIPTION","MASTERFEAT","Constant"],
+  "rows": [
+    {
+      "id": 3003,
+      "key": "feat:weapon_focus_dwaxe",
+      "LABEL": "FEAT_WEAPON_FOCUS_DWAXE",
+      "FEAT": 83318,
+      "DESCRIPTION": "****",
+      "MASTERFEAT": 6,
+      "Constant": "FEAT_WEAPON_FOCUS_DWAXE"
+    }
+  ]
+}`+"\n")
+
+	module := buildGeneratedFeatModuleForTest(t, root, "weapon_focus.json")
+	override := generatedFeatOverrideByKey(t, module, "feat:weapon_focus_dwaxe")
+	if text := generatedFeatOverrideTitle(t, override); text != "Weapon Focus (dwarven waraxe)" {
+		t.Fatalf("expected existing generated family row to receive normalized FEAT TLK text, got %q", text)
+	}
+}
+
 func TestGeneratedSkillFeatTitleStyleFlattensChildParenthetical(t *testing.T) {
 	root := testProjectRoot(t)
 	writeFeatGeneratedHarness(t, root, map[string]string{