From 754375fb087aac28984d8950b3d4467b67227cfe Mon Sep 17 00:00:00 2001 From: gitea-bot Date: Thu, 9 Jul 2026 09:46:59 +0000 Subject: [PATCH] depot: report sweep progress to stderr instead of discarding it (#35) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sweep prints `probed N/M` every 1000 blobs, but every caller passed `io.Discard`, so a full ~71k-blob verify ran ~56 minutes with zero output and looked hung in CI (sow-assets-manifest run 245). `go test ./internal/depot` passes; verified live against the cdn (progress lines now appear on stderr). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: vickydotbat Reviewed-on: https://git.westgate.pw/ShadowsOverWestgate/sow-tools/pulls/35 Co-authored-by: gitea-bot Co-committed-by: gitea-bot --- internal/depot/run.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/internal/depot/run.go b/internal/depot/run.go index 1c49876..a46b1be 100644 --- a/internal/depot/run.go +++ b/internal/depot/run.go @@ -143,7 +143,7 @@ func runStatus(args []string, stdout, stderr io.Writer, getenv func(string) stri } shas := shaKeys(shaSizes) - res, err := Sweep(context.Background(), backend, shas, cfg, io.Discard) + res, err := Sweep(context.Background(), backend, shas, cfg, stderr) if err != nil { fmt.Fprintln(stderr, "depot status:", err) return exitInternal @@ -185,7 +185,7 @@ func runPush(args []string, stdout, stderr io.Writer, getenv func(string) string } shas := shaKeys(shaSizes) - res, err := Sweep(context.Background(), backend, shas, cfg, io.Discard) + res, err := Sweep(context.Background(), backend, shas, cfg, stderr) if err != nil { fmt.Fprintln(stderr, "depot push:", err) return exitInternal @@ -266,7 +266,7 @@ func runVerify(args []string, stdout, stderr io.Writer, getenv func(string) stri } shas := shaKeys(shaSizes) - res, err := Sweep(context.Background(), backend, shas, cfg, io.Discard) + res, err := Sweep(context.Background(), backend, shas, cfg, stderr) if err != nil { fmt.Fprintln(stderr, "depot verify:", err) return exitInternal @@ -389,7 +389,7 @@ func runPull(args []string, stdout, stderr io.Writer, getenv func(string) string // Sweep the source to distinguish "not there" (exit 1, listed) from // "there, download it". - res, err := Sweep(context.Background(), backend, toCheck, cfg, io.Discard) + res, err := Sweep(context.Background(), backend, toCheck, cfg, stderr) if err != nil { fmt.Fprintln(stderr, "depot pull:", err) return exitInternal