Conservative build-haks
In build.go, build-haks now does conservative chunk reuse instead of wiping all generated HAKs up front. It plans chunks as before, computes a deterministic per-chunk content_hash, reuses an existing .hak only when the prior manifest entry and on-disk archive still match, rebuilds only changed chunks, and deletes only stale generated HAKs that fall out of the new plan. I added coverage for unchanged reuse and selective rebuilds in pipeline_test.go, and go test ./... passes in sow-tools.
This commit is contained in:
@@ -6,6 +6,7 @@ import (
|
||||
"path/filepath"
|
||||
"strings"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"gitea.westgate.pw/ShadowsOverWestgate/sow-tools/internal/erf"
|
||||
"gitea.westgate.pw/ShadowsOverWestgate/sow-tools/internal/project"
|
||||
@@ -31,7 +32,7 @@ func TestBuildThenExtract(t *testing.T) {
|
||||
`)
|
||||
|
||||
mustMkdir(t, filepath.Join(root, "src", "module"))
|
||||
mustWriteFile(t, filepath.Join(root, "src", "module", "module.ifo.json"), `{
|
||||
mustWriteFile(t, filepath.Join(root, "src", "module", "module.ifo.json"), `{
|
||||
"file_type": "IFO ",
|
||||
"file_version": "V3.2",
|
||||
"root": {
|
||||
@@ -46,7 +47,6 @@ func TestBuildThenExtract(t *testing.T) {
|
||||
}
|
||||
}
|
||||
`)
|
||||
|
||||
p, err := project.Load(root)
|
||||
if err != nil {
|
||||
t.Fatalf("load project: %v", err)
|
||||
@@ -750,6 +750,231 @@ func TestBuildSkipsEmptyHAKGroupsInModuleOrder(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
func TestBuildHAKsReusesUnchangedChunks(t *testing.T) {
|
||||
root := t.TempDir()
|
||||
mustMkdir(t, filepath.Join(root, "src", "module"))
|
||||
mustMkdir(t, filepath.Join(root, "assets", "core"))
|
||||
mustMkdir(t, filepath.Join(root, "assets", "vfx"))
|
||||
mustMkdir(t, filepath.Join(root, "build"))
|
||||
|
||||
mustWriteFile(t, filepath.Join(root, "nwn-tool.json"), `{
|
||||
"module": {
|
||||
"name": "Test Module",
|
||||
"resref": "testmod",
|
||||
"hak_order": ["group:core", "group:vfx"]
|
||||
},
|
||||
"paths": {
|
||||
"source": "src",
|
||||
"assets": "assets",
|
||||
"build": "build"
|
||||
},
|
||||
"haks": [
|
||||
{
|
||||
"name": "core",
|
||||
"priority": 1,
|
||||
"max_bytes": 1024,
|
||||
"split": false,
|
||||
"include": ["core/**"]
|
||||
},
|
||||
{
|
||||
"name": "vfx",
|
||||
"priority": 2,
|
||||
"max_bytes": 1024,
|
||||
"split": false,
|
||||
"include": ["vfx/**"]
|
||||
}
|
||||
]
|
||||
}`)
|
||||
mustWriteFile(t, filepath.Join(root, "src", "module", "module.ifo.json"), `{
|
||||
"file_type": "IFO ",
|
||||
"file_version": "V3.2",
|
||||
"root": {
|
||||
"struct_type": 0,
|
||||
"fields": [
|
||||
{
|
||||
"label": "Mod_Name",
|
||||
"type": "CExoString",
|
||||
"value": "Test Module"
|
||||
},
|
||||
{
|
||||
"label": "Mod_HakList",
|
||||
"type": "List",
|
||||
"value": []
|
||||
}
|
||||
]
|
||||
}
|
||||
}`)
|
||||
mustWriteFile(t, filepath.Join(root, "assets", "core", "core_a.tga"), "core-a")
|
||||
mustWriteFile(t, filepath.Join(root, "assets", "vfx", "vfx_a.tga"), "vfx-a")
|
||||
|
||||
p, err := project.Load(root)
|
||||
if err != nil {
|
||||
t.Fatalf("load project: %v", err)
|
||||
}
|
||||
if err := p.ValidateLayout(); err != nil {
|
||||
t.Fatalf("validate layout: %v", err)
|
||||
}
|
||||
if err := p.Scan(); err != nil {
|
||||
t.Fatalf("scan: %v", err)
|
||||
}
|
||||
|
||||
if _, err := BuildHAKs(p); err != nil {
|
||||
t.Fatalf("first build haks: %v", err)
|
||||
}
|
||||
corePath := filepath.Join(root, "build", "core.hak")
|
||||
vfxPath := filepath.Join(root, "build", "vfx.hak")
|
||||
coreInfoBefore, err := os.Stat(corePath)
|
||||
if err != nil {
|
||||
t.Fatalf("stat core before: %v", err)
|
||||
}
|
||||
vfxInfoBefore, err := os.Stat(vfxPath)
|
||||
if err != nil {
|
||||
t.Fatalf("stat vfx before: %v", err)
|
||||
}
|
||||
|
||||
time.Sleep(1100 * time.Millisecond)
|
||||
|
||||
if _, err := BuildHAKs(p); err != nil {
|
||||
t.Fatalf("second build haks: %v", err)
|
||||
}
|
||||
coreInfoAfter, err := os.Stat(corePath)
|
||||
if err != nil {
|
||||
t.Fatalf("stat core after: %v", err)
|
||||
}
|
||||
vfxInfoAfter, err := os.Stat(vfxPath)
|
||||
if err != nil {
|
||||
t.Fatalf("stat vfx after: %v", err)
|
||||
}
|
||||
|
||||
if !coreInfoAfter.ModTime().Equal(coreInfoBefore.ModTime()) {
|
||||
t.Fatalf("expected unchanged core.hak to be reused")
|
||||
}
|
||||
if !vfxInfoAfter.ModTime().Equal(vfxInfoBefore.ModTime()) {
|
||||
t.Fatalf("expected unchanged vfx.hak to be reused")
|
||||
}
|
||||
|
||||
rawManifest, err := os.ReadFile(filepath.Join(root, "build", "haks.json"))
|
||||
if err != nil {
|
||||
t.Fatalf("read manifest: %v", err)
|
||||
}
|
||||
var manifest BuildManifest
|
||||
if err := json.Unmarshal(rawManifest, &manifest); err != nil {
|
||||
t.Fatalf("parse manifest: %v", err)
|
||||
}
|
||||
for _, hak := range manifest.HAKs {
|
||||
if hak.ContentHash == "" {
|
||||
t.Fatalf("expected content hash for %s", hak.Name)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestBuildHAKsRebuildsOnlyChangedChunks(t *testing.T) {
|
||||
root := t.TempDir()
|
||||
mustMkdir(t, filepath.Join(root, "src", "module"))
|
||||
mustMkdir(t, filepath.Join(root, "assets", "core"))
|
||||
mustMkdir(t, filepath.Join(root, "assets", "vfx"))
|
||||
mustMkdir(t, filepath.Join(root, "build"))
|
||||
|
||||
mustWriteFile(t, filepath.Join(root, "nwn-tool.json"), `{
|
||||
"module": {
|
||||
"name": "Test Module",
|
||||
"resref": "testmod",
|
||||
"hak_order": ["group:core", "group:vfx"]
|
||||
},
|
||||
"paths": {
|
||||
"source": "src",
|
||||
"assets": "assets",
|
||||
"build": "build"
|
||||
},
|
||||
"haks": [
|
||||
{
|
||||
"name": "core",
|
||||
"priority": 1,
|
||||
"max_bytes": 1024,
|
||||
"split": false,
|
||||
"include": ["core/**"]
|
||||
},
|
||||
{
|
||||
"name": "vfx",
|
||||
"priority": 2,
|
||||
"max_bytes": 1024,
|
||||
"split": false,
|
||||
"include": ["vfx/**"]
|
||||
}
|
||||
]
|
||||
}`)
|
||||
mustWriteFile(t, filepath.Join(root, "src", "module", "module.ifo.json"), `{
|
||||
"file_type": "IFO ",
|
||||
"file_version": "V3.2",
|
||||
"root": {
|
||||
"struct_type": 0,
|
||||
"fields": [
|
||||
{
|
||||
"label": "Mod_Name",
|
||||
"type": "CExoString",
|
||||
"value": "Test Module"
|
||||
},
|
||||
{
|
||||
"label": "Mod_HakList",
|
||||
"type": "List",
|
||||
"value": []
|
||||
}
|
||||
]
|
||||
}
|
||||
}`)
|
||||
mustWriteFile(t, filepath.Join(root, "assets", "core", "core_a.tga"), "core-a")
|
||||
mustWriteFile(t, filepath.Join(root, "assets", "vfx", "vfx_a.tga"), "vfx-a")
|
||||
|
||||
p, err := project.Load(root)
|
||||
if err != nil {
|
||||
t.Fatalf("load project: %v", err)
|
||||
}
|
||||
if err := p.ValidateLayout(); err != nil {
|
||||
t.Fatalf("validate layout: %v", err)
|
||||
}
|
||||
if err := p.Scan(); err != nil {
|
||||
t.Fatalf("scan: %v", err)
|
||||
}
|
||||
|
||||
if _, err := BuildHAKs(p); err != nil {
|
||||
t.Fatalf("first build haks: %v", err)
|
||||
}
|
||||
corePath := filepath.Join(root, "build", "core.hak")
|
||||
vfxPath := filepath.Join(root, "build", "vfx.hak")
|
||||
coreInfoBefore, err := os.Stat(corePath)
|
||||
if err != nil {
|
||||
t.Fatalf("stat core before: %v", err)
|
||||
}
|
||||
vfxInfoBefore, err := os.Stat(vfxPath)
|
||||
if err != nil {
|
||||
t.Fatalf("stat vfx before: %v", err)
|
||||
}
|
||||
|
||||
time.Sleep(1100 * time.Millisecond)
|
||||
mustWriteFile(t, filepath.Join(root, "assets", "core", "core_a.tga"), "core-a-updated")
|
||||
if err := p.Scan(); err != nil {
|
||||
t.Fatalf("rescan after change: %v", err)
|
||||
}
|
||||
|
||||
if _, err := BuildHAKs(p); err != nil {
|
||||
t.Fatalf("second build haks: %v", err)
|
||||
}
|
||||
coreInfoAfter, err := os.Stat(corePath)
|
||||
if err != nil {
|
||||
t.Fatalf("stat core after: %v", err)
|
||||
}
|
||||
vfxInfoAfter, err := os.Stat(vfxPath)
|
||||
if err != nil {
|
||||
t.Fatalf("stat vfx after: %v", err)
|
||||
}
|
||||
|
||||
if !coreInfoAfter.ModTime().After(coreInfoBefore.ModTime()) {
|
||||
t.Fatalf("expected changed core.hak to be rebuilt")
|
||||
}
|
||||
if !vfxInfoAfter.ModTime().Equal(vfxInfoBefore.ModTime()) {
|
||||
t.Fatalf("expected unchanged vfx.hak to be reused")
|
||||
}
|
||||
}
|
||||
func TestExtractOverwritesAndRemovesStaleFiles(t *testing.T) {
|
||||
root := t.TempDir()
|
||||
mustMkdir(t, filepath.Join(root, "src", "module"))
|
||||
|
||||
Reference in New Issue
Block a user