Music Pipeline Configuration Hardening

2026-05-08 11:22:57 +02:00
parent 75942b0940
commit c7fd63a80c
6 changed files with 265 additions and 9 deletions
@@ -3447,6 +3447,146 @@ haks:
 	}
 }

+func TestBuildHAKsConvertsFLACMusicSourcesByDefault(t *testing.T) {
+	root := t.TempDir()
+	mustMkdir(t, filepath.Join(root, "assets", "audio", "westgate"))
+	mustMkdir(t, filepath.Join(root, "build"))
+
+	ffprobePath := filepath.Join(root, "tools", "ffprobe")
+	ffmpegPath := filepath.Join(root, "tools", "ffmpeg")
+	mustMkdir(t, filepath.Dir(ffprobePath))
+	mustWriteFile(t, ffprobePath, "#!/bin/sh\nprintf '%s\\n' '{\"format\":{\"tags\":{\"artist\":\"FLAC Artist\",\"title\":\"FLAC Title\"}}}'\n")
+	mustWriteFile(t, ffmpegPath, "#!/bin/sh\nfor last; do :; done\nprintf 'dataset-bmu' > \"$last\"\n")
+	if err := os.Chmod(ffprobePath, 0o755); err != nil {
+		t.Fatalf("chmod ffprobe: %v", err)
+	}
+	if err := os.Chmod(ffmpegPath, 0o755); err != nil {
+		t.Fatalf("chmod ffmpeg: %v", err)
+	}
+
+	mustWriteFile(t, filepath.Join(root, "nwn-tool.yaml"), `
+module:
+  name: Test Assets
+  resref: testassets
+paths:
+  assets: assets
+  build: build
+music:
+  tools:
+    ffmpeg: tools/ffmpeg
+    ffprobe: tools/ffprobe
+  datasets:
+    westgate_audio:
+      source: audio/westgate
+      output: generated/music
+      prefix: wg_
+haks:
+  - name: music
+    priority: 1
+    max_bytes: 1048576
+    split: false
+    include:
+      - generated/music/**
+`)
+	mustWriteFile(t, filepath.Join(root, "assets", "audio", "westgate", "Theme Song.flac"), "source-flac")
+
+	p, err := project.Load(root)
+	if err != nil {
+		t.Fatalf("load project: %v", err)
+	}
+	if err := p.ValidateLayout(); err != nil {
+		t.Fatalf("validate layout: %v", err)
+	}
+	if err := p.Scan(); err != nil {
+		t.Fatalf("scan: %v", err)
+	}
+
+	result, err := BuildHAKs(p)
+	if err != nil {
+		t.Fatalf("build haks: %v", err)
+	}
+	if result.CreditsSummary.TrackCount != 1 {
+		t.Fatalf("expected one music track, got %#v", result.CreditsSummary)
+	}
+	manifestRaw, err := os.ReadFile(filepath.Join(root, "build", "haks.json"))
+	if err != nil {
+		t.Fatalf("read manifest: %v", err)
+	}
+	manifestText := string(manifestRaw)
+	if !strings.Contains(manifestText, "generated/music/wg_theme.bmu") {
+		t.Fatalf("expected generated FLAC music in manifest, got:\n%s", manifestText)
+	}
+	if strings.Contains(manifestText, "audio/westgate/Theme Song.flac") {
+		t.Fatalf("did not expect source flac in manifest, got:\n%s", manifestText)
+	}
+}
+
+func TestBuildHAKsUsesYAMLMusicConvertExtensionsForDiscovery(t *testing.T) {
+	root := t.TempDir()
+	mustMkdir(t, filepath.Join(root, "assets", "audio", "westgate"))
+	mustMkdir(t, filepath.Join(root, "build"))
+
+	ffprobePath := filepath.Join(root, "tools", "ffprobe")
+	ffmpegPath := filepath.Join(root, "tools", "ffmpeg")
+	mustMkdir(t, filepath.Dir(ffprobePath))
+	mustWriteFile(t, ffprobePath, "#!/bin/sh\nprintf '%s\\n' '{\"format\":{\"tags\":{\"artist\":\"AAC Artist\",\"title\":\"AAC Title\"}}}'\n")
+	mustWriteFile(t, ffmpegPath, "#!/bin/sh\nfor last; do :; done\nprintf 'dataset-bmu' > \"$last\"\n")
+	if err := os.Chmod(ffprobePath, 0o755); err != nil {
+		t.Fatalf("chmod ffprobe: %v", err)
+	}
+	if err := os.Chmod(ffmpegPath, 0o755); err != nil {
+		t.Fatalf("chmod ffmpeg: %v", err)
+	}
+
+	mustWriteFile(t, filepath.Join(root, "nwn-tool.yaml"), `
+module:
+  name: Test Assets
+  resref: testassets
+paths:
+  assets: assets
+  build: build
+music:
+  defaults:
+    convert_extensions:
+      - .aac
+  tools:
+    ffmpeg: tools/ffmpeg
+    ffprobe: tools/ffprobe
+  datasets:
+    westgate_audio:
+      source: audio/westgate
+      output: generated/music
+      prefix: wg_
+haks:
+  - name: music
+    priority: 1
+    max_bytes: 1048576
+    split: false
+    include:
+      - generated/music/**
+`)
+	mustWriteFile(t, filepath.Join(root, "assets", "audio", "westgate", "Theme Song.aac"), "source-aac")
+
+	p, err := project.Load(root)
+	if err != nil {
+		t.Fatalf("load project: %v", err)
+	}
+	if err := p.ValidateLayout(); err != nil {
+		t.Fatalf("validate layout: %v", err)
+	}
+	if err := p.Scan(); err != nil {
+		t.Fatalf("scan: %v", err)
+	}
+
+	result, err := BuildHAKs(p)
+	if err != nil {
+		t.Fatalf("build haks: %v", err)
+	}
+	if result.CreditsSummary.TrackCount != 1 {
+		t.Fatalf("expected one music track discovered through YAML convert_extensions, got %#v", result.CreditsSummary)
+	}
+}
+
 func TestPlanHAKsDoesNotTranscodeMusicSources(t *testing.T) {
 	root := t.TempDir()
 	mustMkdir(t, filepath.Join(root, "assets", "audio", "westgate"))