Support for unique prefixes on 2da conversion

2026-05-15 08:05:42 +02:00
parent f2ade14967
commit d767ec0a25
2 changed files with 195 additions and 10 deletions
@@ -68,6 +68,71 @@ tables:
 	}
 }

+func TestRunConvertCommandInfersOverrideOutputPrefixFromTemplateConfig(t *testing.T) {
+	root := testProjectRoot(t)
+	writeFile(t, filepath.Join(root, "nwn-tool.yaml"), `
+module:
+  name: Test
+  resref: test
+paths:
+  source: src
+  assets: assets
+  build: build
+topdata:
+  source: topdata
+  build: build/topdata
+`)
+	mkdirAll(t, filepath.Join(root, "topdata", "templates"))
+	writeFile(t, filepath.Join(root, "topdata", "templates", "config.yaml"), `
+module_output:
+  filename_prefixes:
+    entries: add
+    override: ovr
+tables:
+  template_appearance:
+    namespace: appearance
+    key_fields:
+      - LABEL
+`)
+	writeFile(t, filepath.Join(root, "topdata", "templates", "template_appearance.2da"), "2DA V2.0\n\nLABEL STRING_REF NAME\n960 \"Zombie, Ash, Hot\" **** Zombie_Ash_Hot\n")
+
+	oldCwd, err := os.Getwd()
+	if err != nil {
+		t.Fatalf("getwd: %v", err)
+	}
+	t.Cleanup(func() {
+		_ = os.Chdir(oldCwd)
+	})
+	if err := os.Chdir(root); err != nil {
+		t.Fatalf("chdir: %v", err)
+	}
+
+	var stdout bytes.Buffer
+	if err := RunConvertCommand([]string{
+		"2da-to-module",
+		"--type", "override",
+		"--name", "ashzombies",
+		"topdata/templates/template_appearance.2da",
+	}, &stdout); err != nil {
+		t.Fatalf("RunConvertCommand failed: %v", err)
+	}
+
+	outputPath := filepath.Join(root, "topdata", "data", "appearance", "modules", "ovr_appearance_ashzombies.json")
+	raw, err := os.ReadFile(outputPath)
+	if err != nil {
+		t.Fatalf("read output: %v", err)
+	}
+	if !strings.Contains(string(raw), `"overrides"`) {
+		t.Fatalf("expected override payload, got:\n%s", string(raw))
+	}
+	if _, err := os.Stat(filepath.Join(root, "topdata", "data", "appearance", "modules", "add_appearance_ashzombies.json")); !os.IsNotExist(err) {
+		t.Fatalf("expected add-prefixed output to be absent, stat err: %v", err)
+	}
+	if !strings.Contains(stdout.String(), "converted overrides: 1") {
+		t.Fatalf("unexpected stdout: %s", stdout.String())
+	}
+}
+
 func TestRunConvertCommand2DAToJSONInfersTemplateKeys(t *testing.T) {
 	root := testProjectRoot(t)
 	writeFile(t, filepath.Join(root, "nwn-tool.yaml"), `
@@ -470,6 +535,54 @@ topdata:
 	}
 }

+func TestRunConvertCommandRejectsUnknownTemplateFilenamePrefixType(t *testing.T) {
+	root := testProjectRoot(t)
+	writeFile(t, filepath.Join(root, "nwn-tool.yaml"), `
+module:
+  name: Test
+  resref: test
+paths:
+  source: src
+  assets: assets
+  build: build
+topdata:
+  source: topdata
+  build: build/topdata
+`)
+	mkdirAll(t, filepath.Join(root, "topdata", "templates"))
+	writeFile(t, filepath.Join(root, "topdata", "templates", "config.yaml"), `
+module_output:
+  filename_prefixes:
+    additions: add
+tables:
+  template_appearance:
+    namespace: appearance
+    key_fields:
+      - LABEL
+`)
+	writeFile(t, filepath.Join(root, "topdata", "templates", "template_appearance.2da"), "2DA V2.0\n\nLABEL\n960 Zombie_Ash_Hot\n")
+
+	oldCwd, err := os.Getwd()
+	if err != nil {
+		t.Fatalf("getwd: %v", err)
+	}
+	t.Cleanup(func() {
+		_ = os.Chdir(oldCwd)
+	})
+	if err := os.Chdir(root); err != nil {
+		t.Fatalf("chdir: %v", err)
+	}
+
+	err = RunConvertCommand([]string{
+		"2da-to-module",
+		"--name", "ashzombies",
+		"topdata/templates/template_appearance.2da",
+	}, &bytes.Buffer{})
+	if err == nil || !strings.Contains(err.Error(), `unsupported module_output.filename_prefixes key "additions"`) {
+		t.Fatalf("expected invalid filename prefix type error, got %v", err)
+	}
+}
+
 func TestConvert2DAToModuleFailsOnDuplicateGeneratedKeysByDefault(t *testing.T) {
 	_, err := convert2DAToModule(parsed2DA{
 		Columns: []string{"LABEL"},