command and help ux pass (#21)

Reviewed-on: #21 Co-authored-by: vickydotbat <vickydotbat@tutamail.com> Co-committed-by: vickydotbat <vickydotbat@tutamail.com>
2026-06-25 09:29:39 +00:00
parent 6afac1a4d9
commit f257672427
29 changed files with 1077 additions and 3151 deletions
@@ -31,7 +31,7 @@ var SourceExtensions = []string{
 }

 var AssetExtensions = []string{
-	".2da", ".bik", ".bmp", ".bmu", ".dds", ".dwk", ".gr2", ".itp", ".jpg", ".lod", ".lyt", ".mdb", ".mdl", ".mdx", ".mp3", ".mtr", ".ogg", ".plt", ".png", ".pwk", ".set", ".shd", ".tga", ".txi", ".uti", ".vis", ".wav", ".wlk", ".wok", ".xml",
+	".2da", ".bik", ".bmp", ".bmu", ".dds", ".dwk", ".gr2", ".itp", ".jpg", ".lod", ".lyt", ".mdb", ".mdl", ".mdx", ".mtr", ".plt", ".png", ".pwk", ".set", ".shd", ".tga", ".txi", ".uti", ".vis", ".wav", ".wlk", ".wok", ".xml",
 }

 var BuiltinScriptPrefixes = []string{
@@ -88,7 +88,6 @@ type Config struct {
 	HAKs       []HAKConfig      `json:"haks" yaml:"haks"`
 	Inventory  InventoryConfig  `json:"inventory" yaml:"inventory"`
 	Validation ValidationConfig `json:"validation" yaml:"validation"`
-	Music      MusicConfig      `json:"music" yaml:"music"`
 	TopData    TopDataConfig    `json:"topdata" yaml:"topdata"`
 	Extract    ExtractConfig    `json:"extract" yaml:"extract"`
 	Autogen    AutogenConfig    `json:"autogen" yaml:"autogen"`
@@ -153,40 +152,6 @@ type HAKConfig struct {
 	Include  []string `json:"include" yaml:"include"`
 }

-type MusicConfig struct {
-	Prefixes map[string]string             `json:"prefixes,omitempty" yaml:"prefixes,omitempty"`
-	Tools    MusicToolsConfig              `json:"tools,omitempty" yaml:"tools,omitempty"`
-	Defaults *MusicDefaultsConfig          `json:"defaults,omitempty" yaml:"defaults,omitempty"`
-	Datasets map[string]MusicDatasetConfig `json:"datasets,omitempty" yaml:"datasets,omitempty"`
-}
-
-type MusicToolsConfig struct {
-	FFmpeg  string `json:"ffmpeg,omitempty" yaml:"ffmpeg,omitempty"`
-	FFprobe string `json:"ffprobe,omitempty" yaml:"ffprobe,omitempty"`
-}
-
-type MusicDefaultsConfig struct {
-	StageRoot         string   `json:"stage_root,omitempty" yaml:"stage_root,omitempty"`
-	CreditsRoot       string   `json:"credits_root,omitempty" yaml:"credits_root,omitempty"`
-	CreditsOverlay    string   `json:"credits_overlay,omitempty" yaml:"credits_overlay,omitempty"`
-	MaxStemLength     *int     `json:"max_stem_length,omitempty" yaml:"max_stem_length,omitempty"`
-	NamingScheme      string   `json:"naming_scheme,omitempty" yaml:"naming_scheme,omitempty"`
-	OutputExtension   string   `json:"output_extension,omitempty" yaml:"output_extension,omitempty"`
-	ConvertExtensions []string `json:"convert_extensions,omitempty" yaml:"convert_extensions,omitempty"`
-}
-
-type MusicDatasetConfig struct {
-	Source            string   `json:"source" yaml:"source"`
-	Output            string   `json:"output,omitempty" yaml:"output,omitempty"`
-	Prefix            string   `json:"prefix,omitempty" yaml:"prefix,omitempty"`
-	StageRoot         string   `json:"stage_root,omitempty" yaml:"stage_root,omitempty"`
-	CreditsRoot       string   `json:"credits_root,omitempty" yaml:"credits_root,omitempty"`
-	NamingScheme      string   `json:"naming_scheme,omitempty" yaml:"naming_scheme,omitempty"`
-	OutputExtension   string   `json:"output_extension,omitempty" yaml:"output_extension,omitempty"`
-	PackageMode       string   `json:"package_mode,omitempty" yaml:"package_mode,omitempty"`
-	ConvertExtensions []string `json:"convert_extensions,omitempty" yaml:"convert_extensions,omitempty"`
-}
-
 type TopDataConfig struct {
 	Source              string                          `json:"source" yaml:"source"`
 	Build               string                          `json:"build" yaml:"build"`
@@ -344,42 +309,42 @@ type AutogenReleaseSourceConfig struct {
 }

 type AutogenProducerConfig struct {
-	ID                string                  `json:"id" yaml:"id"`
-	Root              string                  `json:"root" yaml:"root"`
-	Include           []string                `json:"include" yaml:"include"`
-	Derive            AutogenDeriveConfig     `json:"derive" yaml:"derive"`
-	Manifest          AutogenManifestConfig   `json:"manifest" yaml:"manifest"`
+	ID                     string                       `json:"id" yaml:"id"`
+	Root                   string                       `json:"root" yaml:"root"`
+	Include                []string                     `json:"include" yaml:"include"`
+	Derive                 AutogenDeriveConfig          `json:"derive" yaml:"derive"`
+	Manifest               AutogenManifestConfig        `json:"manifest" yaml:"manifest"`
 	AccessoryVisualeffects AccessoryVisualeffectsConfig `json:"accessory_visualeffects" yaml:"accessory_visualeffects"`
 }

 type AutogenConsumerConfig struct {
-	ID                string                  `json:"id" yaml:"id"`
-	Producer          string                  `json:"producer" yaml:"producer"`
-	Dataset           string                  `json:"dataset" yaml:"dataset"`
-	Mode              string                  `json:"mode" yaml:"mode"`
-	Optional          bool                    `json:"optional,omitempty" yaml:"optional,omitempty"`
-	Root              string                  `json:"root" yaml:"root"`
-	Include           []string                `json:"include" yaml:"include"`
-	Derive            AutogenDeriveConfig     `json:"derive" yaml:"derive"`
-	PartsRows         PartsRowsConfig         `json:"parts_rows" yaml:"parts_rows"`
+	ID                     string                       `json:"id" yaml:"id"`
+	Producer               string                       `json:"producer" yaml:"producer"`
+	Dataset                string                       `json:"dataset" yaml:"dataset"`
+	Mode                   string                       `json:"mode" yaml:"mode"`
+	Optional               bool                         `json:"optional,omitempty" yaml:"optional,omitempty"`
+	Root                   string                       `json:"root" yaml:"root"`
+	Include                []string                     `json:"include" yaml:"include"`
+	Derive                 AutogenDeriveConfig          `json:"derive" yaml:"derive"`
+	PartsRows              PartsRowsConfig              `json:"parts_rows" yaml:"parts_rows"`
 	AccessoryVisualeffects AccessoryVisualeffectsConfig `json:"accessory_visualeffects" yaml:"accessory_visualeffects"`
-	Manifest          AutogenManifestConfig   `json:"manifest" yaml:"manifest"`
-	LocalOverrideRoot string                  `json:"local_override_root,omitempty" yaml:"local_override_root,omitempty"`
-	ManifestFile      string                  `json:"manifest_file,omitempty" yaml:"manifest_file,omitempty"`
-	Source            AutogenSourceConfig     `json:"source,omitempty" yaml:"source,omitempty"`
+	Manifest               AutogenManifestConfig        `json:"manifest" yaml:"manifest"`
+	LocalOverrideRoot      string                       `json:"local_override_root,omitempty" yaml:"local_override_root,omitempty"`
+	ManifestFile           string                       `json:"manifest_file,omitempty" yaml:"manifest_file,omitempty"`
+	Source                 AutogenSourceConfig          `json:"source,omitempty" yaml:"source,omitempty"`
 }

 type AccessoryVisualeffectsConfig struct {
 	Groups             map[string]AccessoryVisualeffectGroupConfig `json:"groups,omitempty" yaml:"groups"`
-	GroupTokenSource   string                                 `json:"group_token_source,omitempty" yaml:"group_token_source"`
-	CategoryFrom       string                                 `json:"category_from,omitempty" yaml:"category_from"`
-	Delimiter          string                                 `json:"delimiter,omitempty" yaml:"delimiter"`
-	Case               string                                 `json:"case,omitempty" yaml:"case"`
-	StripModelPrefixes []string                               `json:"strip_model_prefixes,omitempty" yaml:"strip_model_prefixes"`
-	KeyFormat          string                                 `json:"key_format,omitempty" yaml:"key_format"`
-	LabelFormat        string                                 `json:"label_format,omitempty" yaml:"label_format"`
-	ModelColumn        string                                 `json:"model_column,omitempty" yaml:"model_column"`
-	RowDefaults        map[string]string                      `json:"row_defaults,omitempty" yaml:"row_defaults"`
+	GroupTokenSource   string                                      `json:"group_token_source,omitempty" yaml:"group_token_source"`
+	CategoryFrom       string                                      `json:"category_from,omitempty" yaml:"category_from"`
+	Delimiter          string                                      `json:"delimiter,omitempty" yaml:"delimiter"`
+	Case               string                                      `json:"case,omitempty" yaml:"case"`
+	StripModelPrefixes []string                                    `json:"strip_model_prefixes,omitempty" yaml:"strip_model_prefixes"`
+	KeyFormat          string                                      `json:"key_format,omitempty" yaml:"key_format"`
+	LabelFormat        string                                      `json:"label_format,omitempty" yaml:"label_format"`
+	ModelColumn        string                                      `json:"model_column,omitempty" yaml:"model_column"`
+	RowDefaults        map[string]string                           `json:"row_defaults,omitempty" yaml:"row_defaults"`
 }

 type AccessoryVisualeffectGroupConfig struct {
@@ -750,8 +715,6 @@ func (p *Project) ValidateLayout() error {
 		}
 	}
 	failures = append(failures, validateAutogenConfig(p.Config.Autogen)...)
-	failures = append(failures, validateMusicConfig(p.Config.Music)...)
-
 	hakNames := map[string]struct{}{}
 	for index, hak := range p.Config.HAKs {
 		name := strings.TrimSpace(hak.Name)
@@ -1059,46 +1022,9 @@ func (p *Project) Scan() error {
 	assetDir := p.AssetsDir()
 	var assetFiles []string
 	if assetDir != "" && filepath.Clean(assetDir) != filepath.Clean(p.Root) {
-		musicSourceExts := make(map[string]struct{})
-		for _, ext := range effective.Music.ConvertExtensions {
-			musicSourceExts[ext] = struct{}{}
-		}
-		musicSourceRoots := make(map[string]map[string]struct{})
-		for _, ds := range effective.Music.Datasets {
-			if strings.TrimSpace(ds.Source) == "" {
-				continue
-			}
-			exts := musicSourceRoots[ds.Source]
-			if exts == nil {
-				exts = make(map[string]struct{})
-				musicSourceRoots[ds.Source] = exts
-			}
-			for _, ext := range ds.ConvertExtensions {
-				exts[ext] = struct{}{}
-			}
-			for ext := range musicSourceExts {
-				exts[ext] = struct{}{}
-			}
-		}
 		var err error
 		assetFiles, _, err = scanDir(assetDir, func(path string) bool {
-			rel, err := filepath.Rel(assetDir, path)
-			if err != nil {
-				return false
-			}
-			rel = filepath.ToSlash(rel)
-			ext := strings.ToLower(filepath.Ext(rel))
-			if slices.Contains(effective.Inventory.AssetExtensions, ext) {
-				return true
-			}
-			for root, exts := range musicSourceRoots {
-				if !pathIsUnder(root, rel) {
-					continue
-				}
-				_, ok := exts[ext]
-				return ok
-			}
-			return false
+			return slices.Contains(effective.Inventory.AssetExtensions, strings.ToLower(filepath.Ext(path)))
 		})
 		if err != nil {
 			if errors.Is(err, os.ErrNotExist) {
@@ -1343,33 +1269,6 @@ func (p *Project) TopDataPackageTLKPath() string {
 	return filepath.Join(p.BuildDir(), p.TopDataPackageTLKName())
 }

-func (p *Project) MusicStageDir() string {
-	return p.rootPath(p.EffectiveConfig().Music.StageRoot)
-}
-
-func (p *Project) CreditsDir() string {
-	return p.rootPath(p.EffectiveConfig().Music.CreditsRoot)
-}
-
-func (p *Project) MusicToolPath(path string) string {
-	path = strings.TrimSpace(path)
-	if path == "" {
-		return ""
-	}
-	if filepath.IsAbs(path) {
-		return path
-	}
-	return filepath.Join(p.Root, filepath.FromSlash(path))
-}
-
-func (p *Project) MusicFFmpegPath() string {
-	return p.MusicToolPath(p.EffectiveConfig().Music.Tools.FFmpeg)
-}
-
-func (p *Project) MusicFFprobePath() string {
-	return p.MusicToolPath(p.EffectiveConfig().Music.Tools.FFprobe)
-}
-
 func (p *Project) AutogenCacheDir() string {
 	return p.rootPath(p.EffectiveConfig().Autogen.Cache.Root)
 }
@@ -1459,36 +1358,6 @@ func normalizeConfig(cfg *Config) {
 	for i := range cfg.Autogen.Consumers {
 		cfg.Autogen.Consumers[i].Include = normalizeStringSlice(cfg.Autogen.Consumers[i].Include)
 	}
-	normalizeMusicConfig(&cfg.Music)
-}
-
-func normalizeMusicConfig(music *MusicConfig) {
-	if music.Defaults != nil {
-		music.Defaults.ConvertExtensions = normalizeExtensionSlice(music.Defaults.ConvertExtensions)
-		music.Defaults.OutputExtension = normalizeExtension(music.Defaults.OutputExtension)
-	}
-	if len(music.Prefixes) > 0 && len(music.Datasets) == 0 {
-		datasets := make(map[string]MusicDatasetConfig, len(music.Prefixes))
-		for dir, prefix := range music.Prefixes {
-			source := trimConfigSlashes(filepath.ToSlash(strings.TrimSpace(dir)))
-			if source == "" {
-				continue
-			}
-			key := strings.ReplaceAll(source, "/", "_")
-			datasets[key] = MusicDatasetConfig{
-				Source: source,
-				Prefix: strings.TrimSpace(prefix),
-			}
-		}
-		music.Datasets = datasets
-	}
-	for id, ds := range music.Datasets {
-		ds.Source = trimConfigSlashes(filepath.ToSlash(strings.TrimSpace(ds.Source)))
-		ds.Output = trimConfigSlashes(filepath.ToSlash(strings.TrimSpace(ds.Output)))
-		ds.OutputExtension = normalizeExtension(ds.OutputExtension)
-		ds.ConvertExtensions = normalizeExtensionSlice(ds.ConvertExtensions)
-		music.Datasets[id] = ds
-	}
 }

 func normalizeStringSlice(input []string) []string {
@@ -1982,68 +1851,6 @@ func validatePartsRowsFormat(format string) error {
 	return nil
 }

-func validateMusicConfig(cfg MusicConfig) []error {
-	var failures []error
-	if cfg.Defaults != nil {
-		if cfg.Defaults.MaxStemLength != nil && *cfg.Defaults.MaxStemLength < 3 {
-			failures = append(failures, errors.New("music.defaults.max_stem_length must be at least 3"))
-		}
-		if cfg.Defaults.NamingScheme != "" && cfg.Defaults.NamingScheme != "nwn_bmu" && cfg.Defaults.NamingScheme != "passthrough" {
-			failures = append(failures, fmt.Errorf("music.defaults.naming_scheme %q is not supported", cfg.Defaults.NamingScheme))
-		}
-		if cfg.Defaults.OutputExtension != "" && !strings.HasPrefix(cfg.Defaults.OutputExtension, ".") {
-			failures = append(failures, errors.New("music.defaults.output_extension must start with ."))
-		}
-	}
-	normalizedRoots := map[string]string{}
-	for root, prefix := range cfg.Prefixes {
-		normalizedRoot := trimConfigSlashes(filepath.ToSlash(strings.TrimSpace(root)))
-		if normalizedRoot == "" {
-			failures = append(failures, errors.New("music.prefixes contains an empty root"))
-			continue
-		}
-		if prior, exists := normalizedRoots[normalizedRoot]; exists {
-			failures = append(failures, fmt.Errorf("music.prefixes roots %q and %q normalize to the same path", prior, root))
-		}
-		normalizedRoots[normalizedRoot] = root
-		if strings.TrimSpace(prefix) == "" {
-			failures = append(failures, fmt.Errorf("music.prefixes[%q] must not be empty", root))
-		}
-	}
-	seenSources := map[string]string{}
-	for id, ds := range cfg.Datasets {
-		if strings.TrimSpace(id) == "" {
-			failures = append(failures, errors.New("music.datasets contains an empty key"))
-		} else if strings.Contains(id, "/") || strings.Contains(id, "\\") {
-			failures = append(failures, fmt.Errorf("music.datasets id %q must not contain path separators", id))
-		}
-		source := trimConfigSlashes(filepath.ToSlash(strings.TrimSpace(ds.Source)))
-		if source == "" {
-			failures = append(failures, fmt.Errorf("music.datasets[%q].source is required", id))
-		} else if pathEscapesRoot(source) {
-			failures = append(failures, fmt.Errorf("music.datasets[%q].source must not escape project root", id))
-		} else if prior, exists := seenSources[source]; exists {
-			failures = append(failures, fmt.Errorf("music.datasets[%q].source %q conflicts with dataset %q", id, ds.Source, prior))
-		} else {
-			seenSources[source] = id
-		}
-		output := trimConfigSlashes(filepath.ToSlash(strings.TrimSpace(ds.Output)))
-		if output != "" && pathEscapesRoot(output) {
-			failures = append(failures, fmt.Errorf("music.datasets[%q].output must not escape project root", id))
-		}
-		if ds.NamingScheme != "" && ds.NamingScheme != "nwn_bmu" && ds.NamingScheme != "passthrough" {
-			failures = append(failures, fmt.Errorf("music.datasets[%q].naming_scheme %q is not supported", id, ds.NamingScheme))
-		}
-		if ds.PackageMode != "" && ds.PackageMode != "hak_asset" && ds.PackageMode != "none" {
-			failures = append(failures, fmt.Errorf("music.datasets[%q].package_mode %q is not supported", id, ds.PackageMode))
-		}
-		if ds.OutputExtension != "" && !strings.HasPrefix(ds.OutputExtension, ".") {
-			failures = append(failures, fmt.Errorf("music.datasets[%q].output_extension must start with .", id))
-		}
-	}
-	return failures
-}
-
 func pathEscapesRoot(path string) bool {
 	clean := filepath.Clean(filepath.FromSlash(path))
 	return clean == ".." || strings.HasPrefix(clean, ".."+string(filepath.Separator))