feat(depot): wire depot into dispatch registry and menu
Flip the depot Registry entry to Wired: true with its command list (status/push/verify/get/pull), so crucible depot/depot status/etc. route to depot.Run instead of the fail-closed unwired path. Update dispatch_test.go: the canonical command surface, command-metadata completeness (depot has no AppCommand since it parses its own subcommands), the menu-items test (depot now expected in the menu), and a new test asserting depot's stderr never reaches the dispatcher's "not wired yet" message. Drop the stale "(SeaweedFS)" summary wording. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
@@ -150,7 +150,7 @@ func TestBuilderHelpIsOK(t *testing.T) {
|
||||
|
||||
func TestCanonicalCommandSurface(t *testing.T) {
|
||||
want := map[string][]string{
|
||||
"depot": nil,
|
||||
"depot": {"status", "push", "verify", "get", "pull"},
|
||||
"hak": {"build", "manifest"},
|
||||
"module": {"build", "extract", "validate", "compare", "manifest"},
|
||||
"topdata": {"validate", "build", "package", "compare", "convert"},
|
||||
@@ -172,7 +172,11 @@ func TestRegistryCommandNamesAndAliasesAreUnambiguous(t *testing.T) {
|
||||
for _, builder := range Registry {
|
||||
seen := map[string]bool{}
|
||||
for _, command := range builder.Commands {
|
||||
if command.Name == "" || command.Summary == "" || command.AppCommand == "" || command.Usage == "" {
|
||||
// depot parses its own subcommands and bypasses AppCommand routing
|
||||
// entirely (see the depot special-case in runBuilder), so its
|
||||
// Commands carry no AppCommand.
|
||||
requireAppCommand := builder.Name != "depot"
|
||||
if command.Name == "" || command.Summary == "" || command.Usage == "" || (requireAppCommand && command.AppCommand == "") {
|
||||
t.Errorf("%s has incomplete command metadata: %#v", builder.Name, command)
|
||||
}
|
||||
if seen[command.Name] {
|
||||
@@ -289,15 +293,35 @@ func TestMenuItemsSkipsUnwiredIncludesWired(t *testing.T) {
|
||||
t.Fatal("expected menu items")
|
||||
}
|
||||
sawModuleBuild := false
|
||||
sawDepotStatus := false
|
||||
for _, it := range items {
|
||||
if it.Args[0] == "depot" {
|
||||
t.Errorf("unwired builder %q must not appear in the menu", it.Args[0])
|
||||
}
|
||||
if len(it.Args) == 2 && it.Args[0] == "module" && it.Args[1] == "build" {
|
||||
sawModuleBuild = true
|
||||
}
|
||||
if len(it.Args) == 2 && it.Args[0] == "depot" && it.Args[1] == "status" {
|
||||
sawDepotStatus = true
|
||||
}
|
||||
}
|
||||
if !sawModuleBuild {
|
||||
t.Error("expected 'module build' in the menu")
|
||||
}
|
||||
if !sawDepotStatus {
|
||||
t.Error("expected wired builder 'depot status' in the menu")
|
||||
}
|
||||
}
|
||||
|
||||
// TestDepotRoutesToDepotRun asserts the depot special-case in runBuilder
|
||||
// reaches depot.Run rather than the generic Commands/delegateLegacy path or
|
||||
// the unwired fail-closed path. With no manifests dir present, depot.Run's
|
||||
// status command fails resolving the backend/manifest (exit 70), but the
|
||||
// stderr text must come from depot, never the dispatcher's unwiredMsg.
|
||||
func TestDepotRoutesToDepotRun(t *testing.T) {
|
||||
var out, errw bytes.Buffer
|
||||
code := runBuilder("depot", []string{"status", "--target", "local"}, &out, &errw)
|
||||
if errw.Len() == 0 {
|
||||
t.Fatalf("depot status with no manifests dir: expected an error from depot.Run, got no stderr (exit=%d)", code)
|
||||
}
|
||||
if strings.Contains(errw.String(), "not wired yet") {
|
||||
t.Fatalf("depot status: stderr shows the dispatcher's unwired message, want depot.Run's own error:\n%s", errw.String())
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user