Commit Graph
2 Commits
Author SHA1 Message Date
archvillainetteandClaude Fable 5 cbfce696b2 review: require .2da suffix on race feats tables, shrink rule test compare
ci / ci (pull_request) Successful in 3m28s
build-binaries / build-binaries (push) Canceled after 0s
Review of #94 branch: tighten racialUsableFeatRules to match the spec's
'race_feat_*.2da' (prefix alone would admit a non-2DA dataset), and
replace the test's length-check-plus-loop with one reflect.DeepEqual.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-08-03 20:46:19 +02:00
archvillainetteandClaude Opus 4.8 4346e96b53 feat: generate racial radial rows from race UsableFeat (#94)
ci / ci (pull_request) Successful in 4m9s
Racial spell-like abilities only reach the in-game radial when the feat
has an OnMenu row in every cls_feat_<class>.2da. Racial feats are granted
by race, not by a class, so nothing puts them there automatically - they
were hand-written as ~23 rows in sow-topdata data/classes/feats/global.json
and prepended into every class table. That list drifts: the build already
carried 24 usable racial feats in the race tables but only 23 hand rows,
so one activatable feat was silently missing from the radial.

Generate those rows at build time from the one source that already marks
them - the UsableFeat column in the race feats tables (race_feat_*.2da).
Every feat flagged UsableFeat=1 gets one cls_feat row (List=3,
GrantedOnLevel=99, OnMenu=1) injected into every class table, deduped and
sorted. List=3 keeps it off every level-up selection list, GrantedOnLevel=99
sits above the level cap so no class ever actually grants it, OnMenu=1
renders the button once the creature holds the feat (possession stays the
job of chargen / the login racial-feat sync, sow-codebase#359).

The rules reuse the existing globalRules injection path (same dedup,
feat-existence check and label lookup) but apply unconditionally, so a
leftover hand row in global.json deduplicates to a no-op and the
sow-topdata cleanup can land separately.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-08-03 20:32:07 +02:00