The legacy normalize migration is done (confirmed). This deletes the dead migration path: NormalizeProject + 26 *_migrate.go files, the importLegacyItempropsRegistry cluster, loadLegacyTLK, and their tests (~7.9k lines, -33 files worth). mergeLegacyTLK moved into tlk_native.go since the live TLK compiler still uses it for base_dialog.json. make check passes.
The legacy normalize migration is done (confirmed). This deletes the dead migration path: NormalizeProject + 26 *_migrate.go files, the importLegacyItempropsRegistry cluster, loadLegacyTLK, and their tests (~7.9k lines, -33 files worth). mergeLegacyTLK moved into tlk_native.go since the live TLK compiler still uses it for base_dialog.json. make check passes.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
The one-time legacy normalize migration finished; NormalizeProject had no
production callers. Delete migrate.go, the 26 *_migrate.go files, the
importLegacyItempropsRegistry cluster, loadLegacyTLK, and the 48 test
blocks that only exercised them. mergeLegacyTLK moves to tlk_native.go
because the live TLK compiler still uses it for base_dialog.json.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
archvillainette
scheduled this pull request to auto merge when all checks succeed 2026-07-19 08:41:42 +00:00
archvillainette
canceled auto merging this pull request when all checks succeed 2026-07-19 08:43:16 +00:00
gitea-bot
approved these changes 2026-07-19 08:48:41 +00:00
LGTM. Verified the deletion is complete: no remaining references to any removed identifier (NormalizeProject, importLegacy*, loadLegacyTLK, ...), nothing orphaned in cmd/ or docs, and the kept helpers (legacyTLKData, normalizeLegacyTLKEntries, relocated mergeLegacyTLK) are all still called by the live TLK compiler. go build, go vet, and go test ./internal/topdata/ all pass on the branch.
Nit: missing blank line between almostEqualFloat32 and the relocated mergeLegacyTLK in tlk_native.go (~line 729) — cosmetic only.
LGTM. Verified the deletion is complete: no remaining references to any removed identifier (`NormalizeProject`, `importLegacy*`, `loadLegacyTLK`, ...), nothing orphaned in `cmd/` or docs, and the kept helpers (`legacyTLKData`, `normalizeLegacyTLKEntries`, relocated `mergeLegacyTLK`) are all still called by the live TLK compiler. `go build`, `go vet`, and `go test ./internal/topdata/` all pass on the branch.
Nit: missing blank line between `almostEqualFloat32` and the relocated `mergeLegacyTLK` in tlk_native.go (~line 729) — cosmetic only.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
gitea-bot
The legacy normalize migration is done (confirmed). This deletes the dead migration path: NormalizeProject + 26 *_migrate.go files, the importLegacyItempropsRegistry cluster, loadLegacyTLK, and their tests (~7.9k lines, -33 files worth). mergeLegacyTLK moved into tlk_native.go since the live TLK compiler still uses it for base_dialog.json. make check passes.
🤖 Generated with Claude Code
LGTM. Verified the deletion is complete: no remaining references to any removed identifier (
NormalizeProject,importLegacy*,loadLegacyTLK, ...), nothing orphaned incmd/or docs, and the kept helpers (legacyTLKData,normalizeLegacyTLKEntries, relocatedmergeLegacyTLK) are all still called by the live TLK compiler.go build,go vet, andgo test ./internal/topdata/all pass on the branch.Nit: missing blank line between
almostEqualFloat32and the relocatedmergeLegacyTLKin tlk_native.go (~line 729) — cosmetic only.