fix(module): run scripts/fetch-upstream-manifests #84

Merged
archvillainette merged 1 commits from fix/fetch-upstream-manifests-rename into main 2026-07-31 19:00:26 +00:00
Owner

Closes #83. Part of #54; implements #63 Decision 5 ("Coordinated rename flip").

What changed

One string literal in internal/app/app.go:388:

[]string{"scripts", "fetch-hak-manifest"} -> []string{"scripts", "fetch-upstream-manifests"}

sow-module renamed its half in ShadowsOverWestgate/sow-module#57
(scripts/fetch-hak-manifest.sh -> scripts/fetch-upstream-manifests.sh,
extended to resolve the topdata channel as well). The script name is a
hardcoded path convention shared by the two repos, not config, so both sides
only work when they carry the same name.

No doc in this repo named the old script (grep over the tree found the one
call site only), so nothing else needed touching.

No fallback, by decision

Per #63 Decision 5: no transitional symlink, no Go-side fallback. Both sides
flip and the short broken window is accepted, because the failure is loud and
unmistakable (required project script is missing). A fallback would keep
both names alive forever.

Merge order matters

sow-module/.gitea/workflows/release.yml runs nix flake update sow-tools, so
it always builds against the latest crucible, unpinned. Every crucible module
build in sow-module fails between sow-module#57 merging and a crucible release
carrying this flip. Merge sow-module#57 and cut a crucible release back to
back
to keep that gap short.

Checks

  • go build ./..., go vet ./internal/app/, and the full go test ./... suite pass.
  • No test covers this call path, and none was added: it is a single hardcoded
    constant that has to match the other repo, so a test here could only assert
    the literal against itself. The real check is the sow-module build.

Still open on the issue's "done when"

  • app.go runs scripts/fetch-upstream-manifests
  • no doc in this repo names fetch-hak-manifest
  • a crucible release is cut, and the crucible module build succeeds in a
    sow-module checkout at #57's head — needs a release after this merges

🤖 Generated with Claude Code

Closes #83. Part of #54; implements #63 Decision 5 ("Coordinated rename flip"). ## What changed One string literal in `internal/app/app.go:388`: ```go []string{"scripts", "fetch-hak-manifest"} -> []string{"scripts", "fetch-upstream-manifests"} ``` sow-module renamed its half in ShadowsOverWestgate/sow-module#57 (`scripts/fetch-hak-manifest.sh` -> `scripts/fetch-upstream-manifests.sh`, extended to resolve the topdata channel as well). The script name is a hardcoded path convention shared by the two repos, not config, so both sides only work when they carry the same name. No doc in this repo named the old script (`grep` over the tree found the one call site only), so nothing else needed touching. ## No fallback, by decision Per #63 Decision 5: no transitional symlink, no Go-side fallback. Both sides flip and the short broken window is accepted, because the failure is loud and unmistakable (`required project script is missing`). A fallback would keep both names alive forever. ## Merge order matters `sow-module/.gitea/workflows/release.yml` runs `nix flake update sow-tools`, so it always builds against the latest crucible, unpinned. Every crucible module build in sow-module fails between sow-module#57 merging and a crucible release carrying this flip. **Merge sow-module#57 and cut a crucible release back to back** to keep that gap short. ## Checks - `go build ./...`, `go vet ./internal/app/`, and the full `go test ./...` suite pass. - No test covers this call path, and none was added: it is a single hardcoded constant that has to match the other repo, so a test here could only assert the literal against itself. The real check is the sow-module build. ## Still open on the issue's "done when" - [x] app.go runs `scripts/fetch-upstream-manifests` - [x] no doc in this repo names `fetch-hak-manifest` - [ ] a crucible release is cut, and the crucible module build succeeds in a sow-module checkout at #57's head — needs a release after this merges 🤖 Generated with [Claude Code](https://claude.com/claude-code)
archvillainette added 1 commit 2026-07-31 18:55:43 +00:00
fix(module): run scripts/fetch-upstream-manifests
ci / ci (pull_request) Successful in 3m33s
78d6e5e404
sow-module renamed scripts/fetch-hak-manifest.sh to
scripts/fetch-upstream-manifests.sh (ShadowsOverWestgate/sow-module#57), and
extended it to resolve the topdata channel as well. The script name is a
hardcoded path convention shared by both repos, not config, so the two sides
only work when they carry the same name.

Per #63 Decision 5 ("Coordinated rename flip") there is no transitional
symlink and no Go-side fallback: both sides flip and the short broken window
is accepted, because the failure is loud and unmistakable (required project
script is missing). A fallback would keep both names alive forever.

Closes #83

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
xtul approved these changes 2026-07-31 18:59:15 +00:00
archvillainette merged commit 682f920114 into main 2026-07-31 19:00:26 +00:00
archvillainette deleted branch fix/fetch-upstream-manifests-rename 2026-07-31 19:00:26 +00:00
Sign in to join this conversation.