ShadowsOverWestgate/sow-nodebb-theme
3
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Activity

Drop the every-main-post book icon from search/profile post lists #15

Merged
archvillainette merged 1 commits from fix/search-result-icons into main 2026-07-05 09:11:17 +00:00
Conversation 1 Commits 1 Files Changed 2
+7 -1
archvillainette commented 2026-07-05 08:01:56 +00:00
Owner
Copy Link
Copy Source

Implements Fix 4 of the wiki-links-and-search-followup spec (plugin repo). Removes the {{{ if ./isMainPost }}} fa-book fallback branch from templates/partials/posts_list_item.tpl — it put a book icon on every global-search result title. Only the isWikiArticle badge remains.

Deliberate blast radius: the partial also serves the seven account/profile post lists, which lose the marker too (restores pre-PR-#14 appearance). search-results.tpl untouched; its badge lights up once the companion plugin PR (fix/wiki-links-search-followup) delivers the flags.

Contract test extended to pin the removal; passing.

🤖 Generated with Claude Code

Implements Fix 4 of the wiki-links-and-search-followup spec (plugin repo). Removes the {{{ if ./isMainPost }}} fa-book fallback branch from templates/partials/posts_list_item.tpl — it put a book icon on every global-search result title. Only the isWikiArticle badge remains. Deliberate blast radius: the partial also serves the seven account/profile post lists, which lose the marker too (restores pre-PR-#14 appearance). search-results.tpl untouched; its badge lights up once the companion plugin PR (fix/wiki-links-search-followup) delivers the flags. Contract test extended to pin the removal; passing. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
archvillainette added 1 commit 2026-07-05 08:01:56 +00:00
fix: drop the every-main-post book icon from search/profile post lists 97002e2ff9
archvillainette scheduled this pull request to auto merge when all checks succeed 2026-07-05 08:09:44 +00:00
xtul approved these changes 2026-07-05 09:11:15 +00:00
archvillainette merged commit 848caadb35 into main 2026-07-05 09:11:17 +00:00
archvillainette deleted branch fix/search-result-icons 2026-07-05 09:11:18 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
xtul
Labels
Clear labels
needs-triage
wayfinder:grilling
wayfinder:map
wayfinder:prototype
wayfinder:research
wayfinder:task
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
XeroTwo archvillainette gitea-bot xtul
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ShadowsOverWestgate/sow-nodebb-theme#15